Merged
Conversation
Member
|
Thanks! I was about to send the same PR, just waiting for my rebased branch to build on riscv64-linux. rc2 worked fine so this should be good as well (rc2 is same as the released version). |
ofborg
bot
added
10.rebuild-darwin: 0
trofi
approved these changes
Nov 28, 2021
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Looks great! Built a few libunwind revdeps locally without any problems.
Contributor
|
Result of 286 packages marked as broken and skipped:
3 packages blacklisted:
1937 packages failed to build:
4 packages built:
|
Member
Author
Well.... let's hold this for a while. |
Contributor
Let me know if any build logs would be helpful. |
Contributor
|
Yeah, looking at the build log would be interesting. We can pick one target as an example, say |
Member
|
For the time being, let's perhaps add |
Closed
Contributor
|
libunwind's API almost did not change. I would be very surprised if this update breaks anything. My suspiction is that most build failures are not directly related to this PR. Core libraries of different versions are a bit hard to mix and match if they can end up in a final binary of both versions. |
Contributor
|
I am re‐running a few evaluations to find out more. So far I haven’t found one that failed because of libunwind. |
Member
Author
|
I noticed some evaluation failures when running nixpkgs-review, after the rebase it seems to run fine. |
Contributor
|
Looks like we got two more releases today: https://github.com/libunwind/libunwind/releases |
Member
Author
trofi
approved these changes
Dec 2, 2021
jonringer
approved these changes
Dec 3, 2021
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
LGTM
can stabilize on staging-next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All patches and riscv64-linux support is now upstream.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes